Repository navigation
Conversation
* [Pipe] Fix ConfigRegion remaining event count lookup * [Pipe] Preserve full pipe names in remaining metrics (cherry picked from commit af22584)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #19071 (
af225846393dfc0da265afa80a3bb37f98e85ef0) todev/1.3, based on7f6e63f726fff9cfd4a112d80a5f6930192abb27.ConfigRegion sources register under
pipeName_regionId_creationTime; include the region ID in the remaining-event lookup so registered sources report their pending events. Split global remaining-event and remaining-time metric IDs at the final underscore to preserve complete pipe names and independent creation-time tags when creating and removing gauges.Use the existing
ConfigNodeInfo.CONFIG_REGION_IDconstant on this branch. The backport also includes the two affected metric classes' registration-preserving unbind and synchronization changes from #18748 (b2cc8b521262aec0993d3d223b59502904031c82), which are required to retain the source regression scenarios across metric-service restarts. Port the affected lookup and underscore-name scenarios with their assertions, plus the plain-name coordinator restart baseline.Validation:
PipeConfigNodeMetricsRestartTest: 3 tests passed, 0 failures, 0 errors, 0 skipped.mvn spotless:apply -P with-integration-tests -pl iotdb-core/confignodepassed.git diff --checkpassed.The focused build used JDK 17 and the English locale. Integration tests and distribution assembly were excluded; Checkstyle, RAT, Enforcer, and dependency analysis were skipped.