KNOX-3425: LDAP Proxy disallows anonymous binds to remote backends - #1359
Closed
handavid wants to merge 1 commit into
Closed
KNOX-3425: LDAP Proxy disallows anonymous binds to remote backends#1359handavid wants to merge 1 commit into
handavid wants to merge 1 commit into
Conversation
The LdapProxyBackend.authenticate method will now return false if either the given DN or password is empty to prevent unauthorized and anonymous binds. The UserSearchInterceptor is also updated to not call the backend if the DN or password is empty.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3425 - LDAP Proxy disallows anonymous binds to remote backends
What changes were proposed in this pull request?
The LdapProxyBackend.authenticate method will now return false if either the given DN or password is empty to prevent unauthorized and anonymous binds.
The UserSearchInterceptor is also updated to not call the backend if the DN or password is empty.
Cherry-picks #1358 to v3.0.0
How was this patch tested?
Unit tests added.
Manual tests performed using ldapsearch to attempt anonymous bind that previously succeeded
Integration Tests
integration tests were run locally
UI changes
no UI changes