KNOX-3429: Harden source assembly to exclude build caches, runtime state, and staging dir - #1368
Merged
Merged
Conversation
…ate, and staging dirs The source assembly includes ** from the repo root and excluded only target/, node_modules/, and IDE files. It snapshots the working tree at end-of-build, so leftover artifacts get bundled into knox-<version>-src.zip, bloating it (staging PUTs then fail with svn E175002) and shipping generated keystores/credentials in a source release. Add scoped excludes for Angular/Sonar caches, the root-level release dirs candidate/ (holds a previous *-src.zip) and install/ (a full unpacked binary release with a generated master secret, from install-test-home), runtime state generated outside target/ (data/security, data/ldap-server, data/deployments, logs, *.pid), and JVM crash/heap dumps. Patterns verified against git ls-files to drop no tracked source. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
hanicz
approved these changes
Sep 1, 2026
Test Results 4 files 4 suites 13s ⏱️ Results for commit c3686c2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3429 - Harden source assembly to exclude build caches, runtime state, and staging dir
What changes were proposed in this pull request?
src/assembly.xmlincludes**from the repo root and excluded onlytarget/,node_modules/, andIDE files. Since it snapshots the working tree at end-of-build, leftover artifacts get bundled intoknox-<version>-src.zip- bloating it (staging then fails withsvn E175002on thedistrepo) and shipping generatedkeystores/credentialsin a source release.Adds scoped excludes:
Kept narrow (**/logs/.log not **/.log) to drop no tracked source. Safety net only - staging from a clean checkout remains recommended.
How was this patch tested?
Integration Tests
N/A
UI changes
N/A