[LIVY-1071] Add driver.address.use-hostname RSC config flag - #544
Open
soumyadeeplogin wants to merge 1 commit into
Open
[LIVY-1071] Add driver.address.use-hostname RSC config flag#544soumyadeeplogin wants to merge 1 commit into
soumyadeeplogin wants to merge 1 commit into
Conversation
Adds an opt-in RSCConf key, driver.address.use-hostname (default false), that makes ContextLauncher resolve the RSC driver's address from the hostname reported in RemoteDriverAddress instead of the socket's IP. Existing IP-based behavior is unchanged when the flag is left at its default. Useful for Kubernetes + service-mesh (Istio) deployments where pod IPs are not stable/routable but hostnames are. Authored-by: Venugopal Allenki <vallenki@salesforce.com> Co-authored-by: Soumyadeep Roy <soumyadeep.roy@salesforce.com>
soumyadeeplogin
changed the title
Author
|
Filed https://issues.apache.org/jira/browse/LIVY-1071 for this change. |
Author
De-ASI-INTERFACE
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds an opt-in
RSCConfkey,driver.address.use-hostname(defaultfalse), that makesContextLauncherresolve the RSC driver's address from the hostname reported inRemoteDriverAddressinstead of the socket's IP. Existing IP-based behavior is unchanged when the flag is left at its default.This is useful for Kubernetes + service-mesh (Istio) deployments where pod IPs are not stable/routable but hostnames are.
Originally authored by Venugopal Allenki, extracted and rebased onto current
masterfor upstreaming.How was this patch tested?
Manually verified in a Kubernetes + Istio deployment with the flag enabled and disabled. No new automated unit test was added, matching the scope/testing depth of the related prior contribution (#462), which covered the same RPC handshake path without a dedicated unit test since
RegistrationHandleris a private inner class only exercisable via a full RPC handshake.Note on JIRA
A LIVY JIRA ticket for this change is being filed; will update the title with the ticket number (
[LIVY-xxxx]) once available.