Repository navigation
.asf.yaml: enforce pull request reviews and branch protection on master - #195
Open
Swatantra-66 wants to merge 1 commit into
Open
Swatantra-66 wants to merge 1 commit into
Swatantra-66 wants to merge 1 commit into
Conversation
Require pull request reviews and conversation resolution under the default branch protection ruleset in .asf.yaml. Prevents accidental direct pushes to master by committers and ensures all changes go through code review and CI verification before merge. Fixes apache#130 Signed-off-by: Swatantra Yadav <maverickswatantra@gmail.com>
xiaoxiang781216
approved these changes
Oct 9, 2026
raiden00pl
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #130
Summary & Context
In #130, @raiden00pl noted that direct
git pushtomastersucceeded without requiring a Pull Request or code review. @hartmannathan confirmed with Apache Infra that branch protection rules can be configured directly by the project via.asf.yaml(ASF Infra documentation).Root Cause
In
nuttx-website/.asf.yaml, theDefault Branch Protectionruleset previously only enforced:Because no pull request rule was declared, GitHub treated direct pushes to
masteras permissible for committers with write access.Solution
This PR updates the
Default Branch Protectionruleset in.asf.yamlusing ASF Infra's convenience syntax to add pull request review and conversation resolution enforcement:Key Behaviors & Guarantees
git pushtomasterorrelease/*branches withGH013: Repository rule violations found. All changes must be submitted via a Pull Request.2if the PMC prefers matching the core RTOS policy).publish.shdeploys to theasf-sitebranch, which is untouched by this ruleset.bypass_teams: [root], ensuring ASF Infrastructure administrative bots retain their required bypass access.Verification
apache/infrastructure-asfyamlparser specifications (valid_rulesets_conveniencetest matrix).~DEFAULT_BRANCH(master) and release branches.Signed-off-by: Swatantra Yadav maverickswatantra@gmail.com