Repository navigation
boards/esp32s3: enable CONFIG_SYSTEM_CDCACM for usbnsh configs - #20581
Merged
simbit18 merged 1 commit intoOct 11, 2026
Merged
Conversation
The shared init.rc gates "exec -- sercon" on CONFIG_SYSTEM_CDCACM, so without it these configs boot with no USB console. SYSTEM_CDCACM selects BOARDCTL_USBDEVCTRL, so savedefconfig drops it as redundant. Assisted-by: Kiro:claude-sonnet-5 Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
|
xiaoxiang781216
approved these changes
Oct 11, 2026
simbit18
approved these changes
Oct 11, 2026
JianyuWang0623
marked this pull request as ready for review
October 11, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shared esp32s3 init.rc gates "exec -- sercon" on CONFIG_SYSTEM_CDCACM,
so the usbnsh configs never connect the CDC/ACM gadget and boot with no
USB console after switching to nxinit.
Enable CONFIG_SYSTEM_CDCACM in the usbnsh defconfig of esp32s3-devkit,
esp32s3-eye, esp32s3-lhcbit, esp32s3-meadow and esp32s3-touch-lcd7, the
same fix already applied to esp32s3-xiao in 8bd50d2.
SYSTEM_CDCACM selects BOARDCTL_USBDEVCTRL, so savedefconfig drops the
latter as redundant.
Impact
Restores the USB CDC/ACM console on the five esp32s3 usbnsh configs.
Defconfig-only change.
Testing
savedefconfig (no diff) and full build pass.
(lckfb-szpi); CDC/ACM gadget 0525:a4a7 enumerates and nsh runs on
/dev/ttyACM*: