Skip to content

boards/esp32s3: enable CONFIG_SYSTEM_CDCACM for usbnsh configs - #20581

Merged
simbit18 merged 1 commit into
apache:masterfrom
JianyuWang0623:esp32s3-usbnsh-system-cdcacm
Oct 11, 2026
Merged

simbit18 merged 1 commit into
apache:masterfrom
JianyuWang0623:esp32s3-usbnsh-system-cdcacm

Conversation

@JianyuWang0623

Copy link
Copy Markdown
Contributor

Summary

The shared esp32s3 init.rc gates "exec -- sercon" on CONFIG_SYSTEM_CDCACM,
so the usbnsh configs never connect the CDC/ACM gadget and boot with no
USB console after switching to nxinit.

Enable CONFIG_SYSTEM_CDCACM in the usbnsh defconfig of esp32s3-devkit,
esp32s3-eye, esp32s3-lhcbit, esp32s3-meadow and esp32s3-touch-lcd7, the
same fix already applied to esp32s3-xiao in 8bd50d2.
SYSTEM_CDCACM selects BOARDCTL_USBDEVCTRL, so savedefconfig drops the
latter as redundant.

Impact

Restores the USB CDC/ACM console on the five esp32s3 usbnsh configs.
Defconfig-only change.

Testing

  • All five configs: ./tools/configure.sh :usbnsh, make
    savedefconfig (no diff) and full build pass.
  • Hardware: esp32s3-devkit:usbnsh flashed on an ESP32-S3 board
    (lckfb-szpi); CDC/ACM gadget 0525:a4a7 enumerates and nsh runs on
    /dev/ttyACM*:
nsh> uname -a
NuttX 13.0.1 9d3472d4191 ... xtensa esp32s3-devkit
nsh> ps
  PID PPID ... COMMAND
    2    0 ... init_main
    4    2 ... sh

The shared init.rc gates "exec -- sercon" on CONFIG_SYSTEM_CDCACM, so
without it these configs boot with no USB console.  SYSTEM_CDCACM
selects BOARDCTL_USBDEVCTRL, so savedefconfig drops it as redundant.

Assisted-by: Kiro:claude-sonnet-5
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@github-actions github-actions Bot added Size: XS The size of the change in this PR is very small Board: xtensa labels Oct 11, 2026
@github-actions

Copy link
Copy Markdown

MemBrowse Memory Report

qemu-armv8a

  • Code: .text.init_builtin_run +60 B (+0.0%, 347,480 B)
  • Data: .bss.g_rr_values -12 B (-0.0%, 77,462 B)

qemu-intel64

@JianyuWang0623
JianyuWang0623 marked this pull request as ready for review October 11, 2026 11:38
@simbit18
simbit18 merged commit e40b2b4 into apache:master Oct 11, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Board: xtensa Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants