Repository navigation
arch/arm64/fvp-v8r: Include nuttx/userspace.h for USERSPACE. - #20653
Merged
Merged
Conversation
fvp_boot.c uses USERSPACE in the protected build, but it got nuttx/userspace.h only through stdio.h. stdio.h does not include nuttx/lib/lib.h any more, so fvp-armv8r:pnsh and fvp-armv8r:pnsh_smp do not compile. Include the header directly. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
xiaoxiang781216
approved these changes
Oct 14, 2026
github-actions
Bot
added
Arch: arm64
|
acassis
approved these changes
Oct 14, 2026
🔗 Cross-repo PR dependenciesThe read-only Build run reported the following dependent PR(s) and fetched head SHA(s): CI run: https://github.com/apache/nuttx/actions/runs/38516745428 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fvp-armv8r:pnshandfvp-armv8r:pnsh_smpdo not compile on master:chip/fvp_boot.c:179: error: 'USERSPACE' undeclared.fvp_boot.cusesUSERSPACEin the protected build, but it gotnuttx/userspace.honly indirectly, throughstdio.handnuttx/lib/lib.h. Since #20565,stdio.hdoes not includenuttx/lib/lib.h. This PR includesnuttx/userspace.hdirectly.Impact
Build fix only. These configs fail the
Linux (arm64-01)CI job of every PR. apache/nuttx-apps#3845 fixes the other arm64-01 failure (imx93-evk:optee), so this PR depends on it to pass that job.Testing
fvp-armv8r:pnsh,fvp-armv8r:pnsh_smp: build on master with this PR (they fail without it).tools/checkpatch.sh -fpasses.depends-on: apache/nuttx-apps/pull/3845