Repository navigation
.github/workflows/check.yml: Check pull requests that change only documentation. - #20666
Merged
Merged
Conversation
…umentation. The Check workflow ignored pull requests that change only files in Documentation/, so their commits and files were never checked: no commit message check and no codespell. A spelling error merged this way then fails the check of a later pull request whose commit range includes the documentation commit, because checkpatch.sh checks every file that a commit in the range touches. Run the Check workflow for every pull request. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
requested review from
lupyuen,
raiden00pl and
simbit18
as code owners
October 14, 2026 14:03
xiaoxiang781216
approved these changes
Oct 14, 2026
acassis
approved these changes
Oct 14, 2026
github-actions
Bot
added
Area: CI
Size: XS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/check.ymlhaspaths-ignore: Documentation/**, so a pull request that changes only documentation never runstools/checkpatch.sh: no commit message check and no codespell.A spelling error merged this way breaks later pull requests.
checkpatch.sh -gchecks every file that a commit in the range touches, and the range of thecheckjob can include commits of master.For example #20649 (documentation only) touched
Documentation/os/scheduling/cancellation_points.rst, which has two codespell errors, and thecheckjob of #20634 and #20648 now fails on that file.This change removes the
paths-ignore, so the Check workflow runs for every pull request.Notes:
git diffshows them as "Binary files ... differ", socheckpatch.shdoes not give them tocheck_file(no cvt2utf, no codespell).Documentation/(conf.py,redirects.py,_extensions/*.py) pass black, flake8 and isort.codespell Documentationreports 48 errors in 16 files today (most inDocumentation/ReleaseNotes/). A pull request that touches one of these files must fix the errors first.Impact
CI only. Documentation-only pull requests run the
checkjob (about 1 minute).Testing
./tools/checkpatch.sh -c -u -g 0ae359f913e~1..0ae359f913e(a commit that adds a.jpginDocumentation/) passes../tools/checkpatch.sh -c -u -f Documentation/conf.py Documentation/redirects.py Documentation/_extensions/*.pypasses.tools/checkpatch.sh -c -u -m -gpasses on this commit.