Repository navigation
arch/xtensa/espressif: Include nuttx/kmalloc.h in esp_temperature_sensor.c. - #20678
Merged
Merged
Conversation
…r.c. Indent esp_temperature_sensor_disable() by six spaces, as the rest of the block. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
…sor.c. esp_temperature_sensor_initialize() calls kmm_free(), but the file does not include nuttx/kmalloc.h. It used to come in through stdio.h, which no longer includes it, so esp32s3-ws-lcd128:imu-qmi8658 fails to build: esp_temperature_sensor.c:871:7: error: implicit declaration of function 'kmm_free' Include nuttx/kmalloc.h, as the risc-v copy of the file does. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
github-actions
Bot
added
Arch: xtensa
raiden00pl
approved these changes
Oct 15, 2026
|
simbit18
approved these changes
Oct 15, 2026
jerpelea
approved these changes
Oct 15, 2026
xiaoxiang781216
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends-on: apache/nuttx-apps/pull/3850
Summary
esp_temperature_sensor_initialize()callskmm_free(), butarch/xtensa/src/common/espressif/esp_temperature_sensor.cdoes not includenuttx/kmalloc.h. The declaration used to come in throughstdio.h, which no longer includes it (#20565), soesp32s3-ws-lcd128:imu-qmi8658fails to build:This stops the
xtensa-03CI job (found on apache/nuttx-apps#3850). The risc-v copy of the file already includesnuttx/kmalloc.h.Two commits:
nuttx/kmalloc.h.Impact
Build fix only. No change in behaviour.
Testing
esp32s3-ws-lcd128:imu-qmi8658with xtensa-esp-elf 14.2.0,-Werror, apps master 467e22088 + apache/nuttx-apps#3850:tools/checkpatch.sh -c -u -m -gpasses.