Skip to content

net/usrsock: fail sendmsg when the sum of iov_len overflows #21434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxiang781216 merged 1 commit into from
Nov 5, 2026
+14 −8
Merged

net/usrsock: fail sendmsg when the sum of iov_len overflows #21434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions net/usrsock/usrsock_sendmsg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,16 @@
#include <nuttx/config.h>
#if defined(CONFIG_NET) && defined(CONFIG_NET_USRSOCK)

#include <stdint.h>
#include <string.h>
#include <assert.h>
#include <errno.h>
#include <limits.h>
#include <stdint.h>
#include <string.h>
#include <nuttx/debug.h>

#include <arch/irq.h>

#include <sys/param.h>
#include <sys/socket.h>
#include <nuttx/net/net.h>
#include <nuttx/net/usrsock.h>
Expand Down Expand Up @@ -160,12 +162,16 @@ static int do_sendto_request(FAR struct usrsock_conn_s *conn,

for (i = 0; i < msg->msg_iovlen; i++)
{
req.buflen += msg->msg_iov[i].iov_len;
}
/* The sum of the iov_len values must fit in ssize_t and uint32_t */

if (req.buflen > UINT32_MAX)
{
req.buflen = UINT32_MAX;
if (msg->msg_iov[i].iov_len >
MIN(SSIZE_MAX, UINT32_MAX) - req.buflen)
{
nwarn("WARNING: The sum of the iov_len values is too large\n");
return -EINVAL;
}

req.buflen += msg->msg_iov[i].iov_len;
}

bufs[0].iov_base = (FAR void *)&req;
Expand Down Expand Up @@ -364,7 +370,7 @@ ssize_t usrsock_sendmsg(FAR struct socket *psock,

/* MSG_DONTWAIT is only use in usrsock. */

flags &= ~MSG_DONTWAIT;
flags &= ~MSG_DONTWAIT;

/* Request user-space daemon to close socket. */

Expand Down
Loading