[Fix] Support KEY_DYNAMIC bucket mode in CompactorSinkBuilder - #9338
Open
zhang-arvin wants to merge 1 commit into
Open
[Fix] Support KEY_DYNAMIC bucket mode in CompactorSinkBuilder#9338zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
This closes apache#9256. When using KEY_DYNAMIC bucket mode (bucket = -1 with crossPartitionUpdate), the CALL sys.compact procedure would throw: UnsupportedOperationException: Unsupported bucket mode: KEY_DYNAMIC The CompactorSinkBuilder only handled HASH_FIXED and HASH_DYNAMIC, but KEY_DYNAMIC is also a bucket-aware mode that should use the same buildForBucketAware() path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issues does this PR fix?
Closes #9256.
What changes are included in this PR?
When using KEY_DYNAMIC bucket mode (bucket = -1 with crossPartitionUpdate), the
CALL sys.compactprocedure would throw:The
CompactorSinkBuilderonly handledHASH_FIXEDandHASH_DYNAMICbucket modes, butKEY_DYNAMICis also a bucket-aware mode that should use the samebuildForBucketAware()path.Root Cause
In
CompactorSinkBuilder.build(), the switch statement onBucketModeonly had cases forHASH_FIXEDandHASH_DYNAMIC. TheKEY_DYNAMICcase was missing, causing it to fall through to the default branch which throws anUnsupportedOperationException.Fix
Add
KEY_DYNAMICto the case statement alongsideHASH_DYNAMICso that it also routes tobuildForBucketAware().How was this patch tested?
The change is a one-line addition of a case statement. The
FlinkSinkBuilderalready handlesKEY_DYNAMICby routing tobuildDynamicBucketSink(input, true), confirming that KEY_DYNAMIC is a valid bucket-aware mode that should be supported in the compaction path.