Repository navigation
Fix what the LangChain receiver and plugin lost before 0.6.0 - #83
Merged
Merged
Conversation
An update written before its run's start in one request was completed
only from the arrivals before it. It had no kind, landed as a graph's own
run, and a model call's answer and response body were lost. Every arrival
of a request is now remembered before any is completed. A run's arrivals
in a request are read together, with the earlier start and the later end,
so a failed tool is not joined to a call the model made after the tool
failed. A response body lands after its run's request, so its reply is
read against that request instead of saying there was none.
PATCH /runs/{id} with a body that carries no id was refused by the
receiver and by the collector. LangSmith JS 0.10.8 sends its updates so
when it does not batch, so none of the runs it traced finished. The run is
now the one the path names, and a body that names another run is refused.
The receiver reads a single run by the collector's own rule.
A chat model at the root of its trace holds its messages as a list per
prompt. They were read as one flat list, so the question never opened the
conversation, and with provider bodies off it was not landed. A model
run's messages are now read in both forms.
A trace kept every run it ever saw while any run of it kept arriving, past
the day and the 50,000 runs that bound what is remembered, and every
request saved them all again. A trace now forgets a run when the run is
forgotten, and keeps the runs a remembered run ran inside.
The LangChain plugin filed a tool's changes under the project the
environment names, while a tracer given a project in code sends the run
to that project. It now watches LangChain's tracer start each tool run,
keeping the start a coroutine function when it is one, and reads the
project from the run. The begin, whose scan comes before the tool runs,
is sent by whichever of the tracer and the plugin is told second, which
LangChain does before the tool runs, and once sent no other begin is sent
for the run. A begin whose tracer never comes, as when the tool is
cancelled between the two, is dropped after ten minutes. A tool no tracer
traces, or one traced with tracing turned off, records nothing. A tracer
whose start cannot be wrapped is left alone, and the plugin then files
changes under the environment's project.
CI installs langchain-core and langsmith, at the versions the capture
harness measured, before the shim tests, so the tests of which project a
traced run belongs to run there instead of skipping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the release review of 0.6.0 for the LangChain receiver and the LangChain plugin.
The receiver and collector
request lost its answer and its provider body, and a failed tool could be joined to the wrong call. Every arrival of
a run is now merged (earlier start, later end), and a response lands after its request even when it came first.
Neither LangSmith client measured sends that order; a hand-written one can.
autoBatchTracing: falsesendsPATCH /runs/{id}with no id inthe body, which was refused with 400, so every run's end was lost. The id is taken from the path; a body id that
disagrees is refused. Receiver and collector share one rule.
inputs.messagesis a list of lists, which the readertook for a flat list, so the person's question did not land as external input.
the run is forgotten, keeping the runs a remembered run ran inside.
The plugin
tracer given
project_nameput the run under another one, so changes landed under the wrong conversation. The pluginnow sends a tool's begin record once both it and the tracer have been told of the tool's start, with the project of
the tracer that traces the tool's run. A tool no tracer traces, or traced with tracing turned off, records nothing,
since there is no run to join its changes to. The limits of what it can tell are on the plugin's setup page.
langchain-coreandlangsmithat the versions the capture harness measured, so these tests run there.Checked
make checkpasses; the plugin's 27 tests pass with LangChain installed. Every collector test lands and parsestwice, and each guard was proven by reverting it.