[SPARK-57677][PYTHON][TESTS] Make UDTF cleanup tests tolerate task retries#56755
Open
gaogaotiantian wants to merge 1 commit into
Open
[SPARK-57677][PYTHON][TESTS] Make UDTF cleanup tests tolerate task retries#56755gaogaotiantian wants to merge 1 commit into
gaogaotiantian wants to merge 1 commit into
Conversation
…tries ### What changes were proposed in this pull request? The two UDTF cleanup tests `test_udtf_cleanup_with_exception_in_eval` and `test_udtf_cleanup_with_exception_in_terminate` asserted that the file written by the UDTF's `cleanup` method contained exactly the string `"cleanup"`. This relaxes the assertions to check that `"cleanup"` is present (and, for the eval test, that `"terminate"` is not), instead of requiring an exact match. ### Why are the changes needed? A UDTF task may be retried by the scheduler, in which case `cleanup` runs more than once and the file ends up with multiple `"cleanup"` strings. The exact-match assertion would then fail. Checking for presence makes the tests robust to retries. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The two UDTF cleanup tests
test_udtf_cleanup_with_exception_in_evalandtest_udtf_cleanup_with_exception_in_terminateasserted that the file written by the UDTF'scleanupmethod contained exactly the string"cleanup". This relaxes the assertions to check that"cleanup"is present (and, for the eval test, that"terminate"is not), instead of requiring an exact match.Why are the changes needed?
A UDTF task may be retried by the scheduler, in which case
cleanupruns more than once and the file ends up with multiple"cleanup"strings. The exact-match assertion would then fail. Checking for presence makes the tests robust to retries.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.
Was this patch authored or co-authored using generative AI tooling?
Yes, Claude Code (Opus 4.8 high)