[Fix] Handle NPE when HADOOP_HOME is not set in K8s application mode (#4304) - #4505
Open
zhang-arvin wants to merge 1 commit into
Open
[Fix] Handle NPE when HADOOP_HOME is not set in K8s application mode (#4304)#4505zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Wrap the
Workspace.ARCHIVES_FILE_PATH()call inFlinkApplicationActionServiceImplwith a try-catch block to handle the case whenHADOOP_HOMEis not set in Kubernetes application mode.Why are the changes needed?
Fixes #4304. When deploying Flink jobs in Kubernetes application mode without a Hadoop environment,
Workspace.ARCHIVES_FILE_PATH()throws aNullPointerExceptionbecauseHdfsUtils.getDefaultFS()requiresHADOOP_HOME. This PR catches the exception and logs a warning instead of crashing.Does this PR introduce any user-facing change?
No.