Skip to content

ts-standby fails its own lint; skipTests templates bypass lint/format checks in CI #1023

Description

@katzino

reported via slack

What's broken

A new Actor created from the ts-standby template (via Git integration or CLI) fails its own lint check out of the box:

src/main.ts
  1:1  error  Run autofix to sort these imports!  simple-import-sort/imports

Users expect a freshly created template to pass the lint setup it ships with, and CI pipelines on such repos fail immediately.

Why CI didn't catch it

ts-standby has "skipTests": true in templates/manifest.json. The Node test suite filters out SKIP_TESTS templates entirely (test/templates.test.js:327), so install, npm run lint, format:check and the run are all skipped, not just the run.

Ten templates are currently fully skipped: python-standby, python-crewai, python-mcp-proxy, python-mcp-empty, ts-playwright-test-runner, ts-standby, js-standby, ts-mcp-proxy, ts-mcp-empty, cli-start. Most likely they only need the run step skipped (standby/MCP Actors don't exit by themselves), which is what the narrower skipRunTest flag already does (src/consts.js:12-14: "Structure/install still checked").

Steps to reproduce

  1. Copy templates/ts-standby (or create an Actor from ts_standby via the CLI or Git integration).
  2. npm install && npm run lint
  3. The lint error above appears (reproduced on Node 24 with a fresh install).

Suggested fix

  1. Run eslint --fix on templates/ts-standby/src/main.ts, which moves import http from 'http' below import { Actor } from 'apify'.
  2. For templates that are skipped only because they can't be run locally, switch skipTests → skipRunTest so that install, lint and format are still checked. Then fix whatever lint/format issues that uncovers in the other skipped templates.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working.t-buildersIssues owned by the Builders team.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions