Repository navigation
test: poll for task runs to fix flaky integration tests - #1123
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1123 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 61 61
Lines 5935 5935
=======================================
Hits 5666 5666
Misses 269 269
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 13, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_task_runsfailed on master (run 38285189656) withassert 0 >= 1: the task's run list was empty right aftercall()returned. The run listing is eventually consistent, so a read straight after the run finishes can miss it. The JS client hit the same flake in apify/apify-client-js#1136.Both
test_task_runsandtest_task_last_runnow poll withpoll_until_conditionuntil the API returns the run thatcall()started.test_task_runsalso checks for that run's id instead of just a non-empty page.✍️ Drafted by Claude Code