Repository navigation
fix(coreai_utils): re-export QScheme at package level (#115) - #116
Merged
Merged
Conversation
dengqiaoyu
requested changes
Sep 30, 2026
dengqiaoyu
left a comment
dengqiaoyu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes! Let's keep the fix simple by just re-export it.
Contributor
There was a problem hiding this comment.
No need to add change for such as simple fix.
Contributor
There was a problem hiding this comment.
No need to add test for this, let's keep it simple.
Re-export QScheme from coreai_opt.coreai_utils alongside CompressionGranularity and DType. This resolves an ImportError when executing the documented example in docs/src/utils/coreai_compression.md#L92-L97 and eliminates the orphaned coreai_opt.coreai_utils.common section in auto-generated API documentation. Closes apple#115
rohith500
force-pushed
the
fix/coreai-utils-export-qscheme
branch
from
September 30, 2026 17:01
16dc00b to
71d0d43
Compare
Contributor
Author
|
Updated to remove the test and changelog fragment, leaving only the re-export in |
dengqiaoyu
enabled auto-merge (squash)
September 30, 2026 17:28
dengqiaoyu
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-export
QSchemefromcoreai_opt.coreai_utilsalongsideCompressionGranularityandDType.This resolves #115 by fixing an
ImportErrorwhen executing the documented example indocs/src/utils/coreai_compression.md#L92-L97.