Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/ArgumentParser/Parsing/SplitArguments.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ enum ParsedArgument: Equatable, CustomStringConvertible {
)
let name = Name(baseName)
self =
value.isEmpty
indexOfEqualSign == str.endIndex
? .name(name)
: .nameWithValue(name, String(value))
}
Expand Down
18 changes: 18 additions & 0 deletions Tests/ArgumentParserEndToEndTests/SimpleEndToEndTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,24 @@ extension SimpleEndToEndTests {
}
}

// MARK: Empty option value

private struct Qux: ParsableArguments {
@Option() var output: String
@Argument() var file: String
}

// swift-format-ignore: AlwaysUseLowerCamelCase
// https://github.com/apple/swift-argument-parser/issues/710
extension SimpleEndToEndTests {
func testParsing_EmptyOptionValue() throws {
AssertParse(Qux.self, ["--output=", "file.txt"]) { qux in
XCTAssertEqual(qux.output, "")
XCTAssertEqual(qux.file, "file.txt")
}
}
}

// MARK: Single value Int

private struct Foo: ParsableArguments {
Expand Down
13 changes: 13 additions & 0 deletions Tests/ArgumentParserUnitTests/SplitArgumentTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,19 @@ private func expectElementEqual(
#expect(sut.originalInput == ["--abc=def"])
}

@Test func singleLongOptionWithEmptyValue() async throws {
let sut = try SplitArguments(arguments: ["--abc="])

#expect(sut.elements.count == 1)
try expectIndexEqual(sut, at: 0, inputIndex: 0, subIndex: .complete)
try expectElementEqual(
sut, at: 0, .option(.nameWithValue(.long("abc"), ""))
)

#expect(sut.originalInput.count == 1)
#expect(sut.originalInput == ["--abc="])
}

@Test func multipleShortOptionsCombined() async throws {
let sut = try SplitArguments(arguments: ["-abc"])

Expand Down