Support option completion for default subcommands - #965
Open
pentaoa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a default subcommand's named arguments to its parent command's generated completions, so options and flags remain completable when the default subcommand name is omitted.
The completion metadata retains the owning subcommand for custom completion callbacks and removes duplicate option names inherited through nested defaults. Positional arguments are intentionally not merged because they would compete with explicit subcommand names.
Fixes #488.
Checklist
Testing
swift build --product ArgumentParserswift format lint --stricton all changed Swift filesmathexample match the updated snapshotsThe full Swift test target could not run locally because this host only has Command Line Tools and its SDK does not provide XCTest; the repository CI matrix will run the added tests.
AI assistance: Codex was used to investigate the issue, implement the change, and draft tests and this PR description. I reviewed the diff and verified the behavior described above.