Skip to content

(feat): surface parameter schemas in appwrite_search_tools results - #90

Merged
ChiragAgg5k merged 1 commit into
mainfrom
feat/search-tools-parameter-schemas
Aug 3, 2026
Merged

(feat): surface parameter schemas in appwrite_search_tools results#90
ChiragAgg5k merged 1 commit into
mainfrom
feat/search-tools-parameter-schemas

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

Summary

  • Include a compact params: block on every appwrite_search_tools match (name, JSON Schema type label, required/optional, truncated description) drawn from the existing catalog input_schema.
  • Agents previously only saw bare required names, which led to wrong argument shapes (e.g. object-shaped queries, missing database_id / size).
  • Add unit coverage for users list, database create, and string column create search outputs.

Test plan

  • uv run python -m unittest discover -s tests/unit -v
  • uv run --group dev ruff check src tests
  • uv run --group dev black --check src tests
  • Smoke appwrite_search_tools for list users, create database, and create string column and confirm each hit shows typed params

Agents were only seeing required param names, so they guessed wrong shapes
for queries, IDs, and column size. Include type, required/optional, and
short descriptions from the existing catalog schemas on every match.

Co-authored-by: Cursor <cursoragent@cursor.com>
@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown

Greptile Summary

Adds compact parameter-schema details to every appwrite_search_tools match so callers can construct correctly shaped tool arguments.

  • Formats parameter names, JSON Schema type labels, required status, and truncated descriptions.
  • Orders required parameters before optional parameters.
  • Adds unit coverage for user listing, database creation, and string-column creation search results.

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or independently actionable issues identified.

The formatter handles absent properties, orders required parameters consistently, bounds individual descriptions, and the tests cover representative array, string, number, and boolean schemas.

Important Files Changed

Filename Overview
src/mcp_server_appwrite/operator.py Adds parameter-schema formatting to search results; no concrete actionable defect was established.
tests/unit/test_operator.py Expands fixtures and assertions to cover typed required and optional parameter output.

Reviews (1): Last reviewed commit: "(feat): surface parameter schemas in app..." | Re-trigger Greptile

@ChiragAgg5k
ChiragAgg5k merged commit 5ea2fe4 into main Aug 3, 2026
5 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the feat/search-tools-parameter-schemas branch August 3, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant