Repository navigation
Conversation
afdesk
marked this pull request as ready for review
November 11, 2026 09:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches the
-ubi9-fipsimage from BoringCrypto (GOEXPERIMENT=boringcrypto) to the native BoringCrypto isn't officially supported by the Go team outside Google. Go 1.24+ ships its own FIPS 140-3 module, which we can use instead.Changes
.goreleaser.yaml,goreleaser-e2e.yaml,magefile.go: build the FIPS binary withCGO_ENABLED=0andGOFIPS140=certified(currently resolves tov1.0.0-c2097c7c). Removedboringcrypto,-tags=fipsonlyand the arm64CC/CXXoverrides.cmd/trivy-operator/fipsonly.go.crypto/tls/fipsonlyonly builds withboringcrypto. Withfips140=on,crypto/tlsitself negotiates only FIPS-approved protocol versions, cipher suites, signature algorithms and key exchanges.gcc-aarch64-linux-gnuinstall step, since the build no longer needs CGO.cmd/trivy-operator/main.go: log FIPS status (module version, enforcement) at startup.getting-started/installation/fips.md(image tags,fips140=on/fips140=onlymodes, Helm usage viaimage.tagandextraEnv, limitations).Behavior
DefaultGODEBUG=fips140=on, so FIPS mode is on by default.GODEBUG=fips140=only(e.g. via HelmextraEnv). In this mode, non-approved algorithms return an error or panic.linux/amd64,linux/arm64) are unchanged.Verification
goreleaser build --snapshot --id trivy-operator-fips:go version -mon both binaries showsCGO_ENABLED=0,GOEXPERIMENT=jsonv2,GOFIPS140=v1.0.0-c2097c7c,DefaultGODEBUG=fips140=on.GOFIPS140=certified GODEBUG=fips140=only go test ./pkg/... ./cmd/...: all tests pass.Checklist