[Sollen-R]

Summary

Fix bug where users are unable to log into the site via Facebook SSO/OAuth

Related Issues

Fixes #272
Fixes #514

Current State

When the user clicks the button to sign-in with Facebook, they are redirected to Facebook where they are then shown an "App not active" error. My best guess: this is due to keybr.com trying to use an outdated version of Graph API.

Proposed State

Update Graph API variable to latest version to restore support.

Changes

Modified Files

• packages\keybr-oauth\lib\adapter\facebook\adapter.ts
  • Modified apiVersion to match the latest from Facebook

Code Changes

// apiVersion - before:
const apiVersion = "v17.0";
const authorizationUri = `https://www.facebook.com/${apiVersion}/dialog/oauth`;
const tokenUri = `https://graph.facebook.com/${apiVersion}/oauth/access_token`;
const profileUri = `https://graph.facebook.com/${apiVersion}/me?fields=${[
  "id",
  "email",
  "name",
].join(",")}`;

// apiVersion - after:
const apiVersion = "v26.0";
const authorizationUri = `https://www.facebook.com/${apiVersion}/dialog/oauth`;
const tokenUri = `https://graph.facebook.com/${apiVersion}/oauth/access_token`;
const profileUri = `https://graph.facebook.com/${apiVersion}/me?fields=${[
  "id",
  "email",
  "name",
].join(",")}`;

Testing

• All possible local testing passes
• Tests are green with no regressions

Limitations

• AFAIK it's not possible to test this functionality offline, so there may be other changes required to migrate to the newer API
• I obviously do not have access to the owner's Meta Developer console, and since the in-place version expired over a year ago now, there may be some flags that need to be cleared to re-open this functionality. That part is on the owner alone.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
packages/keybr-oauth/lib/adapter/facebook/adapter.ts	0% smaller