Repository navigation
Conversation
TXyy2023
marked this pull request as ready for review
October 18, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #630.
Canvasscales its context bydevicePixelRatio, butShapes.clear()passes the already scaled canvas width and height toclearRect. When the ratio is below 1 (for example, browser zoom on a standard-density display), the clear rectangle is scaled a second time and leaves the right and bottom edges of the previous chart visible.Save the context, reset its transform while clearing the full backing store, then restore it so subsequent chart drawing keeps the same coordinates and styles.
Validation:
Graphics/Shapesimplementation at DPR 0.5, 0.8, 1, 1.25 and 2. Before the fix, DPR 0.5/0.8 left 60,000/73,728 stale pixels; after the fix, every ratio leaves zero. Transform, styles and subsequent scaled drawing are preserved. This checks the shared rendering primitive, not a full signed-in profile session.npm run compile,npm run stylelint,npm run build -- --no-statsandDATABASE_CLIENT=sqlite npm testpass (all 58 test tasks).Known upstream CI limitation: repository-wide
npm run lintstill reports 24 existing errors in 19 files that are byte-identical to upstream05a37bc5. The upstream CI run also fails at that commit. No checks were skipped or disabled. The focused change is ready for review; the fork workflow awaits maintainer approval.Implemented and validated with OpenAI Codex.