Skip to content

fix(profile): clarify the speed comparison population - #648

Open
TXyy2023 wants to merge 1 commit into
aradzie:masterfrom
TXyy2023:codex/issue-81-speed-comparison-copy
Open

TXyy2023 wants to merge 1 commit into
aradzie:masterfrom
TXyy2023:codex/issue-81-speed-comparison-copy

Conversation

@TXyy2023

@TXyy2023 TXyy2023 commented Oct 18, 2026 •

Copy link
Copy Markdown

Fixes #81.

The speed comparison currently says that the user's average or top speed beats a percentage of other people. The histogram generator actually counts individual qualifying lesson results, and both radio options query the same distribution. This wording leaves the comparison ambiguous and implies a per-person statistic that the data does not represent.

Clarify the four English messages in the speed histogram section: identify the reference population as recorded lesson speeds, explain that average and top speed use the same distribution, and describe the bars and selected-speed marker consistently. Percentile calculations and existing translation IDs are unchanged; updated translations follow the documented POEditor workflow.

Validation:

  • Executed the existing histogram generator with two synthetic user files containing three lessons at 300, 600 and 600 CPM. The normalized bins were 500 and 1000, confirming lesson-frequency weighting. The Linux-oriented utility was built on macOS using compile-time large-file API aliases; its source was unchanged.
  • Rendered the actual React section in the repository's jsdom environment and switched both options. The corrected messages appeared, and the displayed 94.9% / 99.6% values matched the original component.
  • Full compile, stylelint, production build and all 58 package test tasks pass. Changed-file ESLint, Prettier and git diff --check pass.
  • Full lint reports 24 existing errors in 19 source files, all byte-identical to upstream 05a37bc5. The focused change is ready for review; the existing full-repository lint failure remains disclosed and the fork workflow awaits maintainer approval. No checks were disabled.

AI assistance: implemented and validated with OpenAI Codex.

@semanticdiff-com

semanticdiff-com Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  packages/page-profile/lib/profile/SpeedHistogramSection.tsx  41% smaller

@TXyy2023
TXyy2023 marked this pull request as ready for review October 18, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Compare youself' statistics not clear

1 participant