Skip to content

Limit XML clipboard exports - #2361

Merged
anvit merged 4 commits into
artefactual:qa/2.xfrom
danloveg:dev/limit-xml-exports
Sep 23, 2026
Merged

anvit merged 4 commits into
artefactual:qa/2.xfrom
danloveg:dev/limit-xml-exports

Conversation

@danloveg

Copy link
Copy Markdown
Contributor

Sets a limit for XML exports from the clipboard. See the screenshot below for the alert shown when this limit is exceeded. This applies only to information object object XML exports from the clipboard (XML exports from the backend are not limited).

xml_export_screenshot

@sarah-mason sarah-mason added the Community Pull requests that have been contributed from community members outside Artefactual label Jun 2, 2026
@anvit

anvit commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@danloveg I took a look through the PR and it mostly looks good! We were wondering if you'd be able to make export limit a variable that could be configured through the settings (and access it via sfConfig::get) rather than just making it a private variable so that it's possible to customize/change it.

@danloveg
danloveg force-pushed the dev/limit-xml-exports branch from 0c624c5 to 6410ef1 Compare June 15, 2026 14:07
@danloveg

Copy link
Copy Markdown
Contributor Author

@danloveg I took a look through the PR and it mostly looks good! We were wondering if you'd be able to make export limit a variable that could be configured through the settings (and access it via sfConfig::get) rather than just making it a private variable so that it's possible to customize/change it.

Hi @anvit, thanks for taking a look. That makes sense to me, I've added a new setting that can be accessed from the "Clipboard" section of the settings. The default value is 1000

clipboard-setting

@anvit anvit added this to the 2.11 milestone Sep 23, 2026
@anvit
anvit merged commit 6c46934 into artefactual:qa/2.x Sep 23, 2026
6 checks passed
@danloveg
danloveg deleted the dev/limit-xml-exports branch September 24, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Pull requests that have been contributed from community members outside Artefactual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants