Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PBS mirror skips keys it finds in its initial listing. If an upload commits after that listing but its response is lost, boto3 can retry the write and hit the bucket lock. PBS can then report a failure even though R2 already holds the expected bytes. #1433 · R2 bucket locks
The ty 0.0.102 mirror hit bucket-lock errors on several artifacts when it reran after a multipart completion failure. That prompted a check of how the PBS uploader handles the same lock response. ty mirror rerun
PBS keeps boto3’s
upload_filepath. IfPutObjectorCompleteMultipartUploadreturnsObjectLockedByBucketPolicy, PBS reads the exact key and accepts it only if its SHA-256 matches the stagedSHA256SUMS. A missing object, failed read, or mismatch fails the upload. If the finalSHA256SUMSupload hits the same lock error, PBS hashes the local manifest itself for comparison.In a local HTTP test, the server stored the first PUT and closed the connection before responding. Botocore retried, received the lock error, and PBS fetched the same key and verified its digest.