fix(csharp): avoid generating property accessors on const fields with autoImplementedProperties - #2679
Open
alexanderxfgl-bit wants to merge 1 commit into
Conversation
… autoImplementedProperties Fixes asyncapi#2591
✅ Deploy Preview for modelina canceled.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Resolves #2591
Description
When generating C# models for properties declared with
constin the schema and with auto-implemented properties enabled, the generator was emitting invalid C# syntax by adding getter property accessors to a const field:Since C# consts are fields and cannot have property accessors, this results in compiler errors (e.g.
CS0107).This fix removes the
{ getter }accessors when rendering const properties, generating standard const fields instead:Testing
should generate a const string with autoImplementedPropertiestoCSharpGenerator.spec.ts72/72tests passed)