Repository navigation
fix(management): forward custom fetch in createManagementAuth client options - #1433
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
createManagementAuthnow copies thefetchoption into the returnedclientOptions, andManagementAuthClientOptionsdeclares thefetchfield.Before this change, the custom
fetchwas used only for the client credentials token request. Sub-clients created withauth.clientOptionssent Management API requests through the globalfetch.ManagementClientalready forwardsfetch, so this aligns the two, as thecreateManagementAuthdocs describe. The gap is most visible withuseMTLS, where the token request uses the mTLS-configuredfetchbut API calls do not.ManagementAuthClientOptionsgains an optionalfetchfield. No other public API changes..fernignore, alongside the other hand-written unit tests.References
Testing
New unit tests in
src/management/tests/unit/management-auth.test.tsstub the globalfetchto reject and check thatclientOptions.fetchis set and that aUsersClientbuilt fromclientOptionssends requests through the customfetch, with and withoutwithCustomDomainHeader.Without the fix: 3 of 4 new tests fail; requests reach the global
fetch.With the fix:
yarn test:unit(636 passed) andyarn test:wire(2621 passed) pass;yarn build, ESLint and Prettier are clean.This change adds unit test coverage
This change adds integration test coverage
Checklist