Repository navigation
[Portal] Align Doc & Storybook with Radix and deploy it on Skyrocket - #5982
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The portal app shell hides the document scrollbar. Storybook loads that stylesheet in the preview iframe, so long docs pages were clipped. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@rachelleau Who is going to run the |
Contributor
|
Added a commit to move the new dockerfile and nginx config into storybook directory |
tung2744
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/v1prefix.components/v1was only a Storybook title, not a source folder.components/v2stays, because that folder is the current component layer and its titles are derived from the path.update-portal-uiskill so they describe Radix Themes andcomponents/v2instead of FluentUI components that are no longer in the app.@oursky/storybook-addon-commentsand register it in Storybook. The repo is private, so it is installed withfile:portal/vendor/storybook-addon-comments. The portal image Dockerfiles copy that tree beforenpm ci.authgear-portal-storybook, underportal/. nginx serves the static Storybook build and proxies/api/to a comments API backed by Postgres. Deploy withskyrocket deployfromportal/, without--env public.Story titles are Storybook-only. Nothing in the portal app imports
*.stories.portal/src/util/shades.tsand its golden fixtures are unchanged;deriveColorsstill uses them for brand button colors. This project does not deploy the Authgear server.Test plan
cd portal && npm run storybookcomponents/v1groupportal/LoginMethods/LoginMethodChooser,portal/LoginMethods/LoginMethodIcon,portal/LoginMethods/AuthenticationSection,components/CheckboxWithTooltip,portal/Users/AccountStatusDialogcomponents/v2stories still appear (Button, Callout, and the rest)/api/commentscd portal/comments-api && npm testcd portal && npm run typecheckskyrocket deployfromportal/,curl -sS https://authgear-portal-storybook.oursky.dev/api/healthzreturns JSON withschemaReady