Skip to content

[Portal] Align Doc & Storybook with Radix and deploy it on Skyrocket - #5982

Merged
tung2744 merged 9 commits into
authgear:mainfrom
rachelleau:design-doc-updates
Oct 13, 2026
Merged

tung2744 merged 9 commits into
authgear:mainfrom
rachelleau:design-doc-updates

Conversation

@rachelleau

Copy link
Copy Markdown
Contributor

Summary

  • Retitle the five stories that used the components/v1 prefix. components/v1 was only a Storybook title, not a source folder. components/v2 stays, because that folder is the current component layer and its titles are derived from the path.
  • Rewrite the portal UI docs, component guidelines, and the update-portal-ui skill so they describe Radix Themes and components/v2 instead of FluentUI components that are no longer in the app.
  • Vendor @oursky/storybook-addon-comments and register it in Storybook. The repo is private, so it is installed with file:portal/vendor/storybook-addon-comments. The portal image Dockerfiles copy that tree before npm ci.
  • Add a Skyrocket project, authgear-portal-storybook, under portal/. nginx serves the static Storybook build and proxies /api/ to a comments API backed by Postgres. Deploy with skyrocket deploy from portal/, without --env public.

Story titles are Storybook-only. Nothing in the portal app imports *.stories. portal/src/util/shades.ts and its golden fixtures are unchanged; deriveColors still uses them for brand button colors. This project does not deploy the Authgear server.

Test plan

  • cd portal && npm run storybook
  • Confirm the sidebar has no components/v1 group
  • Confirm these titles: portal/LoginMethods/LoginMethodChooser, portal/LoginMethods/LoginMethodIcon, portal/LoginMethods/AuthenticationSection, components/CheckboxWithTooltip, portal/Users/AccountStatusDialog
  • Confirm components/v2 stories still appear (Button, Callout, and the rest)
  • On local Storybook, the Comments panel reports HTTP 404 because there is no /api/comments
  • cd portal/comments-api && npm test
  • cd portal && npm run typecheck
  • After skyrocket deploy from portal/, curl -sS https://authgear-portal-storybook.oursky.dev/api/healthz returns JSON with schemaReady
  • On that site, post, resolve, and delete a comment in the Comments panel

rachelleau and others added 6 commits October 8, 2026 15:46
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@fungc-io
fungc-io requested a review from tung2744 October 8, 2026 15:44
The portal app shell hides the document scrollbar. Storybook loads that stylesheet in the preview iframe, so long docs pages were clipped.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tung2744 tung2744 self-assigned this Oct 9, 2026
@tung2744

Copy link
Copy Markdown
Contributor

@rachelleau Who is going to run the skyrocket deploy? Is that designer will run it manually and no ci is expected to run it?

@tung2744

Copy link
Copy Markdown
Contributor

Added a commit to move the new dockerfile and nginx config into storybook directory

@tung2744
tung2744 merged commit 428adeb into authgear:main Oct 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants