Repository navigation
UX fixes of login id create / list / edit / delete in Settings - #5992
Merged
Merged
Conversation
Hide Edit on the email and phone view pages, reject the edit pages when update_disabled is set, and make settings rows plain text instead of links when the page behind them has nothing to do. ref DEV-3907
Settings rows and Back links used to lead to a list page showing one
identity. Add MakeList{Email,Phone,Username}URL, which return a skip
target when the list holds one item, and use them in templates and in
the redirects after add, edit, verify, change primary and remove.
A settings row now opens the identity's view page, and is plain text
when that page has nothing to do.
ref DEV-3907
The remove form posts x_login_id_key but the handler read x_login_key, so the redirect to the list had an empty key. Also skip the list page when it holds no item, not only one. ref DEV-3907
Also refresh .make-lint-translation-keys-expect for shifted template lines.
carmenlau
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref DEV-3907
Also fixed the problem which sometimes we see a single item list in settings. Now the list is always skipped when there is only 1 login id of that type.