Make file informer resync period configurable#89
Merged
ecordell merged 2 commits intoJul 17, 2026
Conversation
Add a functional-options API to NewFileInformerFactory so callers can override the default 1-minute resync period. A zero value disables synthetic resync events, matching the convention used by client-go informers; negative values fall back to the default. The resync loop now uses a time.Ticker (skipped entirely when resyncs are disabled) instead of a per-iteration context-with-timeout.
golangci-lint v2.12.2's govet flags slices calls from golang.org/x/exp/slices as un-inlineable because type-parameter inference for inlining isn't supported. Switching to the stdlib slices package (available since Go 1.21) resolves the warnings.
ecordell
approved these changes
Jul 17, 2026
ecordell
left a comment
ecordell
left a comment
Contributor
There was a problem hiding this comment.
LGTM
thanks for fixing this long-standing issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a functional-options API to
NewFileInformerFactoryso callers can override the default 1-minute resync period.Existing call sites are unaffected.
Closes #9