Publish shuttle-tokio as 1.0.0 - #327
Merged
Merged
Conversation
This was referenced Aug 22, 2026
sarsko
force-pushed
the
bump-shuttle-tokio-1
branch
from
September 2, 2026 10:24
25489d6 to
e96f8ad
Compare
bkragl
previously approved these changes
Sep 3, 2026
bkragl
reviewed
Sep 3, 2026
| # Wrappers mirror the version of the crate they wrap, so that a downstream crate can depend on the | ||
| # wrapper using the same version requirement it would have used for the real crate. `tokio` is at | ||
| # 1.x, so this is too. | ||
| version = "1.0.0" |
Contributor
There was a problem hiding this comment.
did we make a mistake in other wrappers?
like, shuttle-parking_lot is v0.12.5. seems like it should have been v0.12.0.
sarsko
force-pushed
the
bump-shuttle-tokio-1
branch
from
September 3, 2026 22:43
e96f8ad to
e4a9948
Compare
The wrappers mirror the version of the crate they wrap, so that a downstream crate can depend on the wrapper using the same version requirement it would have used for the real crate. shuttle-parking_lot is 0.12.5 for parking_lot 0.12, shuttle-dashmap is 6.1.0 for dashmap 6.1, shuttle-lazy_static is 1.5.0 for lazy_static 1.5, shuttle-tokio-util is 0.7.0 for tokio-util 0.7, and so on. shuttle-tokio was the exception: it wraps tokio 1.x but was published as 0.1.0. That also made wrappers/README.md self-contradictory, telling users to write `version = "1"` in two places and `version = "0.1.0"` in a third. Bump it to 1.0.0 so it follows the same scheme as its siblings, and fix the one stale reference in wrappers/README.md so all three examples agree. This is a major version bump of an already-published crate (0.1.0 is on crates.io). Nothing in this repository depends on shuttle-tokio -- it is a leaf that only downstream users consume -- so the change is contained to its own manifest.
sarsko
force-pushed
the
bump-shuttle-tokio-1
branch
from
September 4, 2026 18:17
e4a9948 to
7f13da0
Compare
sarsko
enabled auto-merge (squash)
September 4, 2026 18:36
sarsko
disabled auto-merge
September 4, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrappers mirror the version of the crate they wrap, so that a downstream crate can depend on the wrapper using the same version requirement it would have used for the real crate:
shuttle-parking_lotparking_lot0.12shuttle-dashmapdashmap6.1shuttle-lazy_staticlazy_static1.5shuttle-randrand0.8.6shuttle-async-streamasync-stream0.3.6shuttle-tokio-utiltokio-util0.7shuttle-tokio-retrytokio-retry0.3shuttle-tokiotokio1.xshuttle-tokiowas the odd one out. It also madewrappers/README.mdcontradict itself, telling users to writeversion = "1"in two places andversion = "0.1.0"in a third.This bumps it to 1.0.0 so it follows the same scheme as its siblings, and fixes the one stale reference in
wrappers/README.mdso all three examples agree.Notes for review
0.1.0and1.0.0are separate incompatible lines, so anyone currently onversion = "0.1"keeps resolving to 0.1.0 and is not broken by the release; they opt in by changing their requirement to1.shuttle-tokio. It is a leaf that only downstream users consume, so the change is contained to its own manifest. Verified withgrep -rn 'package = "shuttle-tokio"' --include=Cargo.toml, which matches only its own[package]name.shuttle-tokioREADME and crate docs use aVERSION_NUMBERplaceholder rather than a literal, so they needed no change.shuttle-tokio-streamstays at 0.1.0:tokio-streamis itself 0.1.x, so it already matches the scheme.cargo check --workspaceandcargo fmt --all -- --checkclean withRUSTFLAGS=-Dwarnings.No CHANGELOG entry, matching the convention that release-prep PRs aggregate them.
Relation to other open PRs
shuttle_enabler) depends on this, since its dependency onshuttle-tokioneeds the1requirement. It is stacked on this branch and will retarget tomainautomatically once this merges.version = "1"on the strength of this change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.