Skip to content

chore: remove the committed cmake_install.cmake - #40

Merged
Helias merged 1 commit into
masterfrom
chore/remove-cmake-install
Sep 30, 2026
Merged

Helias merged 1 commit into
masterfrom
chore/remove-cmake-install

Conversation

@Helias

@Helias Helias commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

It was generated by someone's local build (D:/3.3.5/... paths) and nothing reads it.

Summary by CodeRabbit

  • Chores
    • Removed the premium module’s installation script. Installation no longer uses this script to select a default install location, configuration, or component, or to report those selections.

It was generated by someone's local build and nothing reads it.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: be1d42b0-6006-481e-8ba9-848020648874

📥 Commits

Reviewing files that changed from the base of the PR and between 5139b0a and bb853ce.

📒 Files selected for processing (1)
  • cmake_install.cmake
💤 Files with no reviewable changes (1)
  • cmake_install.cmake

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request removes cmake_install.cmake from modules/mod-premium. The script previously selected an install prefix, configuration, and component, then reported the selected settings.

Changes

Install Script Removal

Layer / File(s) Summary
Remove install script
modules/mod-premium/cmake_install.cmake
The script’s install-prefix default and normalization, configuration and component selection, and status messages are removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to bb853

Removing the committed install script presents no established merge-blocking risk. Mergeable subject to normal build checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains why the file should be removed, but it omits the required Changes Proposed, Issues Addressed, SOURCE, Tests Performed, and How to Test the Changes sections. Update the description with the required template sections. Describe the proposed change, issue reference or state that none applies, source information if available, tests performed, and step-by-step testing instructions.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: removal of the committed cmake_install.cmake file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Helias
Helias merged commit 4e0664d into master Sep 30, 2026
3 checks passed
@Helias
Helias deleted the chore/remove-cmake-install branch September 30, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant