Make the dispatch menu extensible before its first use - #2195
Merged
Merged
Conversation
projectile-dispatch was a stub until its first invocation, so transient-insert-suffix and friends failed on it with "Not a transient prefix command" unless the user called the private projectile--dispatch-define by hand. Defining the real menu from a with-eval-after-load on transient keeps transient lazily loaded, but makes the menu extensible the moment anything (the user's own require, magit, the stub) loads it.
The upgrade guide only pointed at transient-append-suffix, which leaves out the parts that actually trip people up: the prefix is the projectile-dispatch symbol, the location is an existing entry's key, and transient has to be loaded first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
projectile-dispatchstayed a stub until it was first opened, sotransient-insert-suffixon it failed unless you called the privateprojectile--dispatch-defineyourself. The real menu is now defined when transient loads, so transient still isn't loaded at startup. The upgrade guide also gets a before/after for moving commander methods over.Raised in #2194.
eldev test)M-x checkdocwarnings