Repository navigation
fix: support compressed provider streams on Node 26 - #25
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74d2513d66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return; | ||
| } | ||
|
|
||
| install(); |
There was a problem hiding this comment.
Preserve embedding-provided non-fetch web globals
When an embedding application replaces only a web global such as WebSocket, EventSource, or Headers after this module loads but leaves fetch unchanged, this guard still reaches install(), which overwrites all of those globals. This defeats the embedding-safety behavior implemented for fetch and can break the host application's HTTP or socket instrumentation when it calls startBot(); either preserve each existing replacement or restrict installation to the fetch globals required by the workaround.
Useful? React with 👍 / 👎.
Summary
globalThis.fetchstartBot()runs, leaving setup/status/help side-effect freeValidation
npx vitest run test/http-runtime.test.ts(2 passed, 1 Node-26-only test skipped on local Node 23.11)npm test(441 passed, 1 Node-26-only test skipped)npm run test:coverage(passed; statements/lines 86.63%, branches 80.98%, functions 90.09%)npm run buildThe Node 26 gzip/SSE test cannot run locally because this workstation currently has Node 23.11 only; the CI matrix executes it under Node 26.