Skip to content

fix: declare MAX_ARRAY_LENGTH before instance fields (SpotBugs IMC) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardladenthin merged 1 commit into from
Sep 30, 2026
Merged

fix: declare MAX_ARRAY_LENGTH before instance fields (SpotBugs IMC) #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/main/java/net/ladenthin/streambuffer/StreamBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@ public class StreamBuffer implements Closeable {
static final String EXCEPTION_MESSAGE_VALIDATE_OFFSET_AND_LENGTH_TO_WRITE_INDEX_OUT_OF_BOUNDS_EXCEPTION =
"Invalid offset or length given to validateOffsetAndLengthToWrite.";

/**
* Largest {@code byte[]} length this class allocates: {@code Integer.MAX_VALUE - 8}.
* Same value as {@code jdk.internal.util.ArraysSupport.SOFT_MAX_ARRAY_LENGTH}, mirrored
* because that class is JDK-internal (not exported, absent on Java 8).
* Reason: VMs reserve array header words; HotSpot rejects {@code Integer.MAX_VALUE} and
* {@code Integer.MAX_VALUE - 1} with "Requested array size exceeds VM limit", on any heap size.
*/
static final int MAX_ARRAY_LENGTH = Integer.MAX_VALUE - 8;

/**
* An object to get an unique access to the {@link #buffer}. It is needed to
* get an exclusive access for read and write operations.
Expand Down Expand Up @@ -132,15 +141,6 @@ public class StreamBuffer implements Closeable {
*/
private final AtomicLong totalBytesRead = new AtomicLong();

/**
* Largest {@code byte[]} length this class allocates: {@code Integer.MAX_VALUE - 8}.
* Same value as {@code jdk.internal.util.ArraysSupport.SOFT_MAX_ARRAY_LENGTH}, mirrored
* because that class is JDK-internal (not exported, absent on Java 8).
* Reason: VMs reserve array header words; HotSpot rejects {@code Integer.MAX_VALUE} and
* {@code Integer.MAX_VALUE - 1} with "Requested array size exceeds VM limit", on any heap size.
*/
static final int MAX_ARRAY_LENGTH = Integer.MAX_VALUE - 8;

/**
* Maximum size of a single byte array during consolidation. Default {@link #MAX_ARRAY_LENGTH}.
*/
Expand Down
Loading