Repository navigation
style: clear the remaining clippy and rustfmt findings under all targets - #88
Merged
Merged
Conversation
`cargo clippy --all-features --all-targets` reported four findings in examples and tests, so the repository could not gate on that flag set: a redundant borrow in a println, two hand-rolled div_ceil calls, and an assert_eq against a literal bool.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The four small edits preserve intended behavior, are compatible with the declared Rust minimum version, and leave no unresolved findings.
No open issues 🎉
What changed in this PR
This PR clears four Clippy findings in OneIO’s examples and tests, enabling strict lint checks across all features and targets without changing production behavior.
Changes:
- Replace manual ceiling division with
div_ceilin S3 tests. - Simplify a boolean assertion.
- Use inline formatting in the CSV-in-tar example.
| File | Description |
|---|---|
| tests/s3_large_upload.rs | Simplify the expected multipart count calculation. |
| tests/basic_integration.rs | Assert reader success directly. |
| src/s3/mod.rs | Simplify the chunk-count assertion in a unit test. |
| examples/read_csv_in_tar.rs | Remove a redundant borrow through inline formatting. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy --all-features --all-targetsreported four findings in examples and tests, so the repository could not gate on that flag set.Changes
println!u64::div_ceilinstead of hand-rolled ceiling divisionFormatting was already clean in these files after
cargo fmt.Testing
cargo fmt --checkcargo clippy --all-features --all-targets -- -D warningscargo test --all-features(11 test binaries, all pass)