Skip to content

style: clear the remaining clippy and rustfmt findings under all targets - #88

Merged
digizeph merged 1 commit into
mainfrom
chore/lint-clean-all-targets
Oct 24, 2026
Merged

digizeph merged 1 commit into
mainfrom
chore/lint-clean-all-targets

Conversation

@digizeph

Copy link
Copy Markdown
Member

Summary

cargo clippy --all-features --all-targets reported four findings in examples and tests, so the repository could not gate on that flag set.

Changes

  • examples/read_csv_in_tar.rs: drop a redundant borrow in a println!
  • tests/s3_large_upload.rs, src/s3/mod.rs: use u64::div_ceil instead of hand-rolled ceiling division
  • tests/basic_integration.rs: assert the bool directly

Formatting was already clean in these files after cargo fmt.

Testing

  • cargo fmt --check
  • cargo clippy --all-features --all-targets -- -D warnings
  • cargo test --all-features (11 test binaries, all pass)

`cargo clippy --all-features --all-targets` reported four findings in examples
and tests, so the repository could not gate on that flag set: a redundant
borrow in a println, two hand-rolled div_ceil calls, and an assert_eq against a
literal bool.
Copilot AI balanced review requested due to automatic review settings October 24, 2026 12:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The four small edits preserve intended behavior, are compatible with the declared Rust minimum version, and leave no unresolved findings.

No open issues 🎉

What changed in this PR

This PR clears four Clippy findings in OneIO’s examples and tests, enabling strict lint checks across all features and targets without changing production behavior.

Changes:

  • Replace manual ceiling division with div_ceil in S3 tests.
  • Simplify a boolean assertion.
  • Use inline formatting in the CSV-in-tar example.
File Description
tests/​s3_large_upload.rs Simplify the expected multipart count calculation.
tests/​basic_integration.rs Assert reader success directly.
src/​s3/​mod.rs Simplify the chunk-count assertion in a unit test.
examples/​read_csv_in_tar.rs Remove a redundant borrow through inline formatting.

Review effort: Balanced

@digizeph
digizeph merged commit f87c241 into main Oct 24, 2026
8 checks passed
@digizeph
digizeph deleted the chore/lint-clean-all-targets branch October 24, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants