Repository navigation
ci: lint examples and tests too - #89
Merged
Merged
Conversation
`cargo clippy --all-targets` passes with all three feature sets, so the workflow can cover examples and test targets instead of only the library and binaries. The four findings that blocked this were fixed in f87c241.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently broaden lint coverage without altering existing checks, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Expands CI lint coverage to include examples and test targets across all three existing feature configurations.
Changes:
- Adds
--all-targetsto the all-features, no-default-features, and default-features Clippy commands. - Preserves existing feature selection and strict warning enforcement (
-D warnings).
| File | Description |
|---|---|
.github/workflows/rust.yml |
Extends all three Clippy steps to lint all targets. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy --all-targetsnow passes with all three feature sets (all, default, none), so the workflow can cover examples and test targets instead of only the library and binaries. The four findings that blocked this were fixed in f87c241.Changes
--all-targets.Testing
cargo clippy --all-features --all-targets -- -D warningscargo clippy --no-default-features --all-targets -- -D warningscargo clippy --all-targets -- -D warnings