chore(deps): bump bdk-ffi to a5f1a45c - #124
Conversation
| @Native<RustBuffer Function(RustBuffer, Pointer<RustCallStatus>)>( | ||
| assetId: _uniffiAssetId, | ||
| ) | ||
| external RustBuffer | ||
| uniffi_bdkffi_fn_method_addforeignutxoerror_uniffi_trait_debug( | ||
| RustBuffer ptr, | ||
| Pointer<RustCallStatus> uniffiStatus, | ||
| ); |
There was a problem hiding this comment.
non blocking: Display,Debug for errors landed here, but Exception toString never calls them. Logging still gets the static Dart strings (e.g. MissingUtxoAddForeignUtxoException), I believe this needs an upstream uniffi-dart fix.
There was a problem hiding this comment.
yeah I think that's right that this might be in uniffi-dart
There was a problem hiding this comment.
Could you open a bdk-dart issue so we can track the current behavior? Eventually we can link an upstream issue/PR from uniffi-dart and update our pin once it’s fixed.
Johnosezele
left a comment
Johnosezele
left a comment
There was a problem hiding this comment.
non blocking: could these new 3.1 methods benefit from smoke coverage?
- CreateParams / LoadParams
- SignersContainer / signWithSigners
- coinSelection
- extractTxUncheckedFeeRate / extractTxWithFeeRateLimit
- Descriptor.asPublic
- onlyConfiguredPeers
- loadFromTwoPath*
Even tiny tests would help prove they are callable from Dart. Fine as a follow up before release if you prefer not to block this bump.
Yeah sounds like they could benefit from smoke coverage. Want to take that on? |
Yeah, i'll follow up with it |
3 participants
Bumps bdk-ffi to a5f1a45c on master which incorporates bdk_wallet 3.1.0, and regenerates the Dart bindings.
(This follows the same process used for previous bdk-dart dependency bumps and mirrors the recent downstream updates in bdk-rn and bdk-jvm ahead of the bdk-ffi 3.1.0 release.)