Add maintainers section to CONTRIBUTING.md - #521
Open
notmandatory wants to merge 1 commit into
Open
Conversation
notmandatory
requested review from
ValuedMammal and
oleonardolima
as code owners
July 29, 2026 19:51
notmandatory
force-pushed
the
docs/update_contributing
branch
from
July 29, 2026 19:53
11dfdd2 to
ecbda92
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 25 25
Lines 6487 6487
Branches 296 296
=======================================
Hits 5309 5309
Misses 1078 1078
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
notmandatory
force-pushed
the
docs/update_contributing
branch
from
July 29, 2026 20:57
ecbda92 to
0102c27
Compare
ValuedMammal
reviewed
Aug 6, 2026
notmandatory
force-pushed
the
docs/update_contributing
branch
from
August 14, 2026 14:26
0102c27 to
22f61f6
Compare
notmandatory
force-pushed
the
docs/update_contributing
branch
from
August 14, 2026 14:28
22f61f6 to
3c4b3c5
Compare
Member
Author
|
I added this to the next milestone but if it doesn't get adequate review can move to the next one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I borrowed from the rust-bitcoin CONTRIBUTING.md file to add a maintainers section to our CONTRIBUTING.md file. The main points I wanted to clarify are:
onetwo maintainers must ACK a PR who is not the original author.Notes to the reviewers
If these changes work for
bdk_walletI'll propose the same change on our other repos. I will also reach out to current maintainers to suggest additional people who they would like to add (and are willing to be) maintainers. Having only two per repo does seem to be enough, the rust-bitcoin team has eight people with maintainer rights.Changelog notice
Before submitting