fix(playground): show the error CODE in the Pull lab, not just the message - #556
Open
IgorShevchik wants to merge 1 commit into
Open
IgorShevchik wants to merge 1 commit into
IgorShevchik wants to merge 1 commit into
Conversation
…ssage The lab reported `error.message`, which is the `SdkError` description. After #555 there are three distinct ways a Pull send fails — `JSSDK_PULL_PUBLIC_IDS_UNAVAILABLE` (nobody to send to), `JSSDK_PULL_SEND_REFUSED` (the transport would not take the frame) and `JSSDK_PULL_PUBLISHING_DISABLED` (the portal forbids it) — and the code is what tells them apart and what a caller branches on. Two of the three read alike from the message alone. Check 9 now also says what the expected outcome IS in an application: a fail carrying `[JSSDK_PULL_PUBLIC_IDS_UNAVAILABLE]`, because `pull.channel.public.list` is not in the application REST surface. Without that line the honest result looks like a defect, and — since until 3.0.0 the same situation reported success and dropped the message in silence — seeing the code is precisely the evidence that the fix is in the build being run. Playground only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F22e2ft66y7nuBJjzdThBr
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#555 gave Pull sends three distinct failures:
JSSDK_PULL_PUBLIC_IDS_UNAVAILABLEJSSDK_PULL_SEND_REFUSEDJSSDK_PULL_PUBLISHING_DISABLEDThe lab printed
error.message— theSdkErrordescription — and dropped thecode. That is the field a caller branches on, and two of the three read alike
without it. Verifying #555 on a portal was therefore harder than it needed to
be.
What changed
errorText()prefixes the code when the error carries one, so a failed checkreads
[JSSDK_PULL_SEND_REFUSED] Pull: the connector refused the frame ….Check 9 also now states what the expected outcome is in an application: a
fail carrying
[JSSDK_PULL_PUBLIC_IDS_UNAVAILABLE], becausepull.channel.public.listis not in the application REST surface. Without thatline an honest result looks like a defect — and since until 3.0.0 the same
situation reported success and dropped the message in silence, seeing that
code is precisely the evidence that the fix is in the build being run. The
playground README says the same.
Testing
Playground only; nothing in
packages/changes.playground-nuxt:typecheck,lint,lint:mdclean; unit suite 92 files / 1152 tests green.🤖 Generated with Claude Code
https://claude.ai/code/session_01F22e2ft66y7nuBJjzdThBr
Generated by Claude Code