refactor(config): improve startup errors and remove inactive assertions

actuator/src/main/java/org/tron/core/vm/repository/RepositoryImpl.java

@@ -924,7 +924,6 @@ private long increase(long lastUsage, long usage, long lastTime, long now, long
     }
 
     if (lastTime != now) {
-      assert now > lastTime;
       if (lastTime + windowSize > now) {
         long delta = now - lastTime;
         double decay = (windowSize - delta) / (double) windowSize;
@@ -973,8 +972,6 @@ public long calculateGlobalEnergyLimit(AccountCapsule accountCapsule) {
     long totalEnergyLimit = getDynamicPropertiesStore().getTotalEnergyCurrentLimit();
     long totalEnergyWeight = getDynamicPropertiesStore().getTotalEnergyWeight();
 
-    assert totalEnergyWeight > 0;
-
     if (hardenResourceCalculation()) {
       return BigInteger.valueOf(energyWeight)
           .multiply(BigInteger.valueOf(totalEnergyLimit))

chainbase/src/main/java/org/tron/common/zksnark/MerklePath.java

@@ -75,7 +75,6 @@ private static long convertVectorToLong(List<Boolean> v) throws ZksnarkException
   }
 
   public byte[] encode() throws ZksnarkException {
-    assert (authenticationPath.size() == index.size());
     List<List<Byte>> pathByteList = Lists.newArrayList();
     long indexLong; // 64
     for (int i = 0; i < authenticationPath.size(); i++) {

chainbase/src/main/java/org/tron/core/db/EnergyProcessor.java

@@ -155,8 +155,6 @@ public long calculateGlobalEnergyLimit(AccountCapsule accountCapsule) {
     long totalEnergyWeight = dynamicPropertiesStore.getTotalEnergyWeight();
     if (dynamicPropertiesStore.allowNewReward() && totalEnergyWeight <= 0) {
       return 0;
-    } else {
-      assert totalEnergyWeight > 0;
     }
     if (hardenCalculation()) {
       return calculateGlobalLimitV1(frozeBalance, totalEnergyLimit, totalEnergyWeight);
@@ -205,4 +203,3 @@ private long scaleByRate(long value, long numerator, long denominator) {
   }
 }
 
-

chainbase/src/main/java/org/tron/core/db/ResourceProcessor.java

@@ -63,7 +63,6 @@ protected long increase(long lastUsage, long usage, long lastTime, long now, lon
     }
 
     if (lastTime != now) {
-      assert now > lastTime;
       if (lastTime + windowSize > now) {
         long delta = now - lastTime;
         double decay = (windowSize - delta) / (double) windowSize;

common/src/main/java/org/tron/core/config/args/CommitteeConfig.java

@@ -1,11 +1,14 @@
 package org.tron.core.config.args;
 
+import static org.tron.core.exception.TronError.ErrCode.PARAMETER_INIT;
+
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigBeanFactory;
 import com.typesafe.config.ConfigValue;
 import lombok.Getter;
 import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
+import org.tron.core.exception.TronError;
 
 /**
  * Committee (governance) configuration bean.
@@ -160,11 +163,11 @@ private void postProcess() {
     // cross-field: allowOldRewardOpt requires at least one reward/vote flag
     if (allowOldRewardOpt == 1 && allowNewRewardAlgorithm != 1
         && allowNewReward != 1 && allowTvmVote != 1) {
-      throw new IllegalArgumentException(
+      throw new TronError(
           "At least one of the following proposals is required to be opened first: "
               + "committee.allowNewRewardAlgorithm = 1"
               + " or committee.allowNewReward = 1"
-              + " or committee.allowTvmVote = 1.");
+              + " or committee.allowTvmVote = 1.", PARAMETER_INIT);
     }
   }
 }

common/src/test/java/org/tron/core/config/args/CommitteeConfigTest.java

@@ -5,6 +5,7 @@
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigFactory;
 import org.junit.Test;
+import org.tron.core.exception.TronError;
 
 public class CommitteeConfigTest {
 
@@ -57,7 +58,7 @@ public void testDynamicEnergyThresholdClamped() {
         .getDynamicEnergyThreshold());
   }
 
-  @Test(expected = IllegalArgumentException.class)
+  @Test(expected = TronError.class)
   public void testAllowOldRewardOptWithoutPrerequisites() {
     CommitteeConfig.fromConfig(withRef("committee { allowOldRewardOpt = 1 }"));
   }

framework/src/main/java/org/tron/core/config/args/Args.java

@@ -1045,8 +1045,9 @@ private static void loadDnsPublishParameters(NodeConfig.DnsConfig dns,
       String serverType = dns.getServerType();
       if (StringUtils.isNotEmpty(serverType)) {
         if (!"aws".equalsIgnoreCase(serverType) && !"aliyun".equalsIgnoreCase(serverType)) {
-          throw new IllegalArgumentException(
-              "Check node.dns.serverType, must be aws or aliyun");
+          throw new TronError(
+              "Check node.dns.serverType, must be aws or aliyun",
+              TronError.ErrCode.PARAMETER_INIT);
         }
         if ("aws".equalsIgnoreCase(serverType)) {
           publishConfig.setDnsType(DnsType.AwsRoute53);
@@ -1088,7 +1089,8 @@ private static void loadDnsPublishParameters(NodeConfig.DnsConfig dns,
   }
 
   private static void logEmptyError(String arg) {
-    throw new IllegalArgumentException(String.format("Check %s, must not be null or empty", arg));
+    throw new TronError(String.format("Check %s, must not be null or empty", arg),
+        TronError.ErrCode.PARAMETER_INIT);
   }
 
   // createTriggerConfig removed — logic moved to applyEventConfig()
@@ -1315,4 +1317,3 @@ private static Map<String, String[]> getOptionGroup() {
     return optionGroupMap;
   }
 }
-

framework/src/main/java/org/tron/core/trie/TrieImpl.java

@@ -762,7 +762,6 @@ private void parse() {
 
     public Node branchNodeGetChild(int hex) {
       parse();
-      assert getType() == NodeType.BranchNode;
       Object n = children[hex];
       if (n == null && parsedRlp != null) {
         if (parsedRlp.isList(hex)) {
@@ -782,15 +781,13 @@ public Node branchNodeGetChild(int hex) {
 
     public Node branchNodeSetChild(int hex, Node node) {
       parse();
-      assert getType() == NodeType.BranchNode;
       children[hex] = node == null ? NULL_NODE : node;
       dirty = true;
       return this;
     }
 
     public byte[] branchNodeGetValue() {
       parse();
-      assert getType() == NodeType.BranchNode;
       Object n = children[16];
       if (n == null && parsedRlp != null) {
         byte[] bytes = parsedRlp.getBytes(16);
@@ -806,15 +803,13 @@ public byte[] branchNodeGetValue() {
 
     public Node branchNodeSetValue(byte[] val) {
       parse();
-      assert getType() == NodeType.BranchNode;
       children[16] = val == null ? NULL_NODE : val;
       dirty = true;
       return this;
     }
 
     public int branchNodeCompactIdx() {
       parse();
-      assert getType() == NodeType.BranchNode;
       int cnt = 0;
       int idx = -1;
       for (int i = 0; i < 16; i++) {
@@ -831,7 +826,6 @@ public int branchNodeCompactIdx() {
 
     public boolean branchNodeCanCompact() {
       parse();
-      assert getType() == NodeType.BranchNode;
       int cnt = 0;
       for (int i = 0; i < 16; i++) {
         cnt += branchNodeGetChild(i) == null ? 0 : 1;
@@ -844,39 +838,33 @@ public boolean branchNodeCanCompact() {
 
     public TrieKey kvNodeGetKey() {
       parse();
-      assert getType() != NodeType.BranchNode;
       return (TrieKey) children[0];
     }
 
     public Node kvNodeGetChildNode() {
       parse();
-      assert getType() == NodeType.KVNodeNode;
       return (Node) children[1];
     }
 
     public byte[] kvNodeGetValue() {
       parse();
-      assert getType() == NodeType.KVNodeValue;
       return (byte[]) children[1];
     }
 
     public Node kvNodeSetValue(byte[] value) {
       parse();
-      assert getType() == NodeType.KVNodeValue;
       children[1] = value;
       dirty = true;
       return this;
     }
 
     public Object kvNodeGetValueOrNode() {
       parse();
-      assert getType() != NodeType.BranchNode;
       return children[1];
     }
 
     public Node kvNodeSetValueOrNode(Object valueOrNode) {
       parse();
-      assert getType() != NodeType.BranchNode;
       if (valueOrNode instanceof byte[] && children[1] instanceof byte[]
           && (children[1] == valueOrNode
           || Arrays.equals((byte[]) children[1], (byte[]) valueOrNode))) {