refactor(config): improve startup errors and remove inactive assertions

[bladehan1]

What does this PR do?

• Replace selected startup IllegalArgumentException failures with TronError(PARAMETER_INIT).
• Remove selected historical Java assertions that are inactive under the default production JVM configuration.
• Preserve the assertions in the EthereumJ-derived TrieImpl and the Besu-derived Blake2bfMessageDigest implementations.
• Add focused unit and integration tests for the affected configuration error paths.

Why are these changes required?

The selected failures are parameter initialization errors. Classifying them with PARAMETER_INIT makes startup failures consistent while preserving their messages and exit behavior.

The assertion cleanup is limited to historical java-tron code where the assertions are inactive by default. Assertions in TrieImpl are retained because its core implementation is derived from EthereumJ and the checks document internal node-type invariants. The Besu-derived Blake2bf assertion is retained for the same upstream-maintenance reason. Keeping these assertions avoids unnecessary divergence from their source implementations; replacing them with production runtime checks, if required, should be evaluated separately.

This PR has been tested by:

• Unit tests:
  • ./gradlew :common:test --tests org.tron.core.config.args.CommitteeConfigTest
  • ./gradlew :framework:test --tests org.tron.core.config.args.ArgsTest
  • ./gradlew -g /private/tmp/java-tron-gradle-home :framework:test --tests org.tron.core.tire.TrieTest
• Coverage reports:
  • ./gradlew :common:jacocoTestReport :framework:jacocoTestReport
  • Verified zero missed instructions for CommitteeConfig.java:166 and Args.java:1048,1092.
• Checkstyle:
  • ./gradlew :framework:checkstyleTest
• Whitespace validation:
  • git diff --check

Follow up

Other startup failures and any replacement of upstream-derived assertions with explicit runtime checks should be evaluated separately according to their semantics and performance impact.

Extra details

• Valid configuration and Trie behavior are unchanged.
• No protocol, database, network, or performance impact is expected.
• TrieImpl and Blake2bfMessageDigest are excluded from the assertion-removal scope.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e8d904ec-25a1-4906-9e94-8d770ceb1baf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[bladehan1]

Automated review by the Codex review pipeline.

Decision: Approve with one concern
Findings: P0=0, P1=1, P2=0, nit=0

NOTE: This review contains AI suggestions; human reviewers retain final judgment.

[bladehan1]

[SHOULD] Clear the shared Args state after the expected failure

Args.applyConfigParams(config) updates several shared Args/CommonParameter fields before CommitteeConfig.fromConfig() throws the expected TronError. This test does not call Args.clearParam(), and the class has no common @After cleanup, so the partially initialized configuration can leak into later tests that share the same JVM. The neighboring applyConfigParams tests already clear this state.

Suggestion: guarantee Args.clearParam() with try/finally around this assertion, or add equivalent cleanup that also covers exceptional exits.