Skip to content

ci: optimize pull request checks - #47

Draft
bladehan1 wants to merge 1 commit into
developfrom
feature/ci_refactor
Draft

ci: optimize pull request checks#47
bladehan1 wants to merge 1 commit into
developfrom
feature/ci_refactor

Conversation

@bladehan1

@bladehan1 bladehan1 commented Aug 5, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

  • Remove four invocation-wide --no-build-cache flags from Debian and Coverage Base builds and RocksDB tests.
  • Recommend type(scope): description while tolerating the common omission of its single space; multiple spaces and other whitespace remain invalid.
  • Route a bare ci: description title to the existing ci reviewer scope; explicit scopes still take precedence and other bare types retain default reviewers.
  • Remove two tracked 0-byte Java placeholder files from chainbase.

Why are these changes required?

The repository already enables Gradle Build Cache. However, four x86 Gradle invocations disable task-output cache reads and writes globally. Removing those flags enables reuse for eligible compile, package, Checkstyle, and test tasks.

CONTRIBUTING.md permits both scoped and bare PR titles. Since ci is also an existing reviewer scope, a bare ci type can be mapped without inventing mappings for unrelated types.

This PR has been tested by:

  • YAML AST parsing for .github/workflows/pr-build.yml, .github/workflows/pr-check.yml, and .github/workflows/pr-reviewer.yml
  • Positive and negative PR-title regular-expression cases
  • Reviewer extraction cases for explicit scopes, bare ci, and other bare types
  • Verification that the four x86 commands no longer contain --no-build-cache
  • git diff --check
  • Forced local execution without task-cache reuse: ./gradlew -g /private/tmp/java-tron-gradle-home :framework:checkstyleMain :framework:checkstyleTest :plugins:checkstyleMain --no-daemon --no-build-cache
  • Local :framework:testWithRocksDb clean/restore validation: stable task key and successful FROM-CACHE restoration

Follow up

  • Change a task-relevant input and confirm that Gradle executes the affected task instead of returning FROM-CACHE.
  • Use task-specific --rerun if a future test contract requires real execution for every CI run.

Extra details

  • clean removes project build/ output but does not remove $GRADLE_USER_HOME/caches/build-cache-1; eligible outputs can therefore be restored after clean.
  • This PR does not change node runtime, consensus, state, database, RPC, configuration, or protocol behavior.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 123a5afa-3b07-49c0-b998-69c6810e8635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bladehan1
bladehan1 force-pushed the feature/ci_refactor branch 2 times, most recently from 201fbff to a669ba9 Compare August 6, 2026 09:32
enable task-output caching for x86 build and coverage jobs
align PR title validation and reviewer routing with contributing rules
remove empty Java placeholder files
@bladehan1
bladehan1 force-pushed the feature/ci_refactor branch from a669ba9 to 97a3250 Compare August 6, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant