feat(config): use reference RocksDB defaults - #50
Draft
bladehan1 wants to merge 1 commit into
Draft
Conversation
Remove the shipped dbSettings overrides so config.conf inherits the documented reference defaults. Keep explicit user overrides available and cover the effective default values with a regression test. Closes #49
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the unverified
storage.dbSettingsoverrides from the shippedconfig.conf, allowing RocksDB defaults to come fromreference.conf.Add a regression test covering the effective block size, L0 compaction
trigger, and target file size.
Why are these changes required?
The shipped configuration overrides the documented RocksDB defaults without
representative production evidence.
In a fixed 500-block Mainnet replay, activating the combined intended options
reduced throughput from 2.421 blocks/s to 1.969 and 1.680 blocks/s. Restoring
the established effective options produced 2.418 blocks/s.
Explicit operator overrides remain supported. This change does not claim or
introduce a new optimized RocksDB profile.
This PR has been tested by:
./gradlew :framework:test --tests org.tron.core.config.ConfigurationTest./gradlew :framework:checkstyleMain./gradlew :framework:checkstyleTestFollow up
Build representative SR block-production benchmarks and observability before
selecting another RocksDB performance profile.
Extra details
No API, protocol, or database-format changes are introduced.
Closes #49
Summary by cubic
Use RocksDB defaults from reference.conf by removing unverified overrides in the shipped config. This restores documented defaults and avoids the observed throughput regression on Mainnet replay.
config.confset custom RocksDBstorage.dbSettings(e.g., blocksize=64KB, L0 compaction trigger=4, target file size base=256MB).config.confno longer setsstorage.dbSettings; effective options come fromreference.conf(blocksize=16KB, L0 compaction trigger=2, target file size base=64MB). Explicit operator overrides still work.Rollout
storage.dbSettingsexplicitly in your config (e.g., blocksize=64, level0FileNumCompactionTrigger=4, targetFileSizeBase=256, plus any related keys you relied on).Written for commit bd3ec32. Summary will update on new commits.