Skip to content

test: filling gaps in MAS and SW - #569

Open
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:test/mas-sw-characterization
Open

test: filling gaps in MAS and SW#569
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:test/mas-sw-characterization

Conversation

@Becheler

@Becheler Becheler commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Adding test support before tackling fixes:
#297
#286

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Adding tests.

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

Motivation

Testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@Becheler Becheler self-assigned this Aug 20, 2026
@Becheler Becheler added the test Adding, fixing or modernizing unit tests label Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 32476722625 vs develop run 32455728120 (62e4282215).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 68 → 68 (0)

@github-actions

github-actions Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 32476722624 vs develop run 32455728113 (62e4282215).

Job Baseline After Delta
macos (clang, 14) 703 702 -1
macos (clang, 17) 663 662 -1
macos (clang, 20) 663 662 -1
ubuntu (clang-19, 14) 703 702 -1
ubuntu (clang-19, 17) 663 662 -1
ubuntu (clang-19, 20) 663 662 -1
ubuntu (clang-19, 23) 663 662 -1
ubuntu (gcc-14, 14) 874 872 -2
ubuntu (gcc-14, 17) 1010 1008 -2
ubuntu (gcc-14, 20) 1010 1008 -2
ubuntu (gcc-14, 23) 1010 1008 -2
windows_msvc_14_3 (msvc-14.3) 962 962 0

@Becheler
Becheler force-pushed the test/mas-sw-characterization branch from 817b58a to 002b0ae Compare August 20, 2026 10:13
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Becheler
Becheler force-pushed the test/mas-sw-characterization branch 4 times, most recently from 87186f5 to 1aec9e2 Compare August 20, 2026 15:32
jeremy-murphy
jeremy-murphy requested changes Aug 21, 2026
View reviewed changes
Comment thread test/stoer_wagner_test.cpp Outdated
Comment on lines +56 to +58
std::mt19937 rng(static_cast< std::mt19937::result_type >(seed));
const undirected_graph g = mas_sw_oracle::make_random_connected_graph(n, n, rng);
BOOST_TEST(mas_sw_oracle::is_connected(g));

@jeremy-murphy jeremy-murphy Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this practice is probably widespread in BGL, but I'm generally against using randomness in unit tests. What we want is careful selection of inputs that trigger different conditions inside the algorithms. Fuzzing has its place, but not here.

@Becheler Becheler Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ? You want to manually define inputs ? I think I agree with the idea, but practically what if outputs are not trivial given the input ? And how to test for scale effects ?

@Becheler
Becheler force-pushed the test/mas-sw-characterization branch from 1aec9e2 to 1a4d086 Compare August 21, 2026 08:27
@Becheler
Becheler requested a review from jeremy-murphy August 21, 2026 08:51
@Becheler
Becheler force-pushed the test/mas-sw-characterization branch from 1a4d086 to 162a82b Compare August 21, 2026 09:37
@Becheler
Becheler force-pushed the test/mas-sw-characterization branch from 162a82b to 62e4282 Compare August 21, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremy-murphy jeremy-murphy Awaiting requested review from jeremy-murphy jeremy-murphy is a code owner

Assignees

@Becheler Becheler

Labels

test Adding, fixing or modernizing unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Becheler @jeremy-murphy