Repository navigation
refactor: keep the --report-skip sections in one list, fix the --wide help - #787
Open
NotAFlightRisk wants to merge 2 commits into
Open
NotAFlightRisk wants to merge 2 commits into
NotAFlightRisk wants to merge 2 commits into
Conversation
pr-insights
Bot
added
L/complexity
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On #778 I floated pulling the
--report-skipnames into one place, so here's roughly what that'd look like. They were typed out separately in the lookup, the unknown-section warning and the flag help, and one test kept its own copy that was still missingcoupling. Now there's one slice and the rest read from it. The--report-skiphelp and the warning print exacly what they did before.A new section name only goes in one place now, and the README checks from #779 go red until both spots in the README catch up.
The
--widehelp also said it "implies --complexity", but there's no such flag (scc --complexitygivesunknown flag). What it actually does is keep complexity on even with-c, so it says "overrides --no-complexity" now, same as--exclude-extwords it.I explicitly licence this contribution under the MIT licence.