Repository navigation
fix: fix paymentButtons color preservation in Demo - #1716
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The behavior fix needs an entry under the changelog’s unreleased section.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Preserves selected PayPal and Venmo button colors across Demo configuration changes.
Changes:
- Saves selected color indices with
rememberSaveable. - Hoists segmented-button selection state.
- Recomputes button colors from saved indices.
| File | Description |
|---|---|
Demo/src/main/java/com/braintreepayments/demo/ComposeUIComponentsFragment.kt |
Persists and restores payment-button color selection. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| setContent { | ||
| var venmoStyle: VenmoButtonColor by remember { mutableStateOf(VenmoButtonColor.Blue) } | ||
| var paypalStyle: PayPalButtonColor by remember { mutableStateOf(PayPalButtonColor.Blue) } | ||
| var venmoStyleId by rememberSaveable { mutableIntStateOf(VenmoButtonColor.Blue.key) } |
saralvasquez
approved these changes
Sep 28, 2026
saralvasquez
left a comment
saralvasquez
left a comment
Contributor
There was a problem hiding this comment.
Works great! Thanks for doing this is being open to a simpler execution!
buzzamus
approved these changes
Sep 29, 2026
buzzamus
left a comment
buzzamus
left a comment
Contributor
There was a problem hiding this comment.
This approach is nice and simple! I like it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
We noticed that the color of the payment button is defaulting to blue ("default color") after orientation change, this PR fixes that in the Demo app
rememberSaveableinstead of simplerememberto save the int as a style selection index.SingleChoiceSegmentedButtonthat will pass the index of the button style to the functionScreen.Recording.2026-09-28.at.4.33.13.PM.mov
AI Usage
Which AI Agent Was Used?
How was AI used?
Solution brainstorming
Estimated AI Code Contribution
Checklist
Authors