Repository navigation
fix: assert n_ticks >= 2 when SetupAxisTicks gets custom labels - #205
Merged
Merged
Conversation
SetupAxisTicks(idx, v_min, v_max, n_ticks, labels) silently raised n_ticks to 2 and then read labels[1], past the end of a caller's array that had a single label. With custom labels it now asserts that n_ticks is at least 2. Mirrors epezent/implot#677.
brenocq
added
type:fix
github-actions
Bot
added
status:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
SetupAxisTicks(axis, v_min, v_max, 1, labels)with a one-elementlabelsarray read past the end of the array. The range overload quietly raisesn_ticksto 2 and then readslabels[1], so the second tick label is garbage or a crash (AddressSanitizer reports a stack-buffer-overflow).It now asserts that
n_ticksis at least 2 when custom labels are given, so the mistake is reported instead of reading out of bounds. Calls without labels still clamp to 2 as before. Mirrors epezent/implot#677.