Skip to content

Username and password seems to have no effect #352

Description

@woodsidenetworksadmin

When authenticating to the server, once you have enrolled a device and have a client cert, if the user account's password is changed, it does not stop further sessions. If the account is disabled, you can no longer log in, same if its deleted. But ... if you re-enable the account, or even recreate the account, that user can authenticate again with the old client certificate.

This seems to originate from the following code in EudHandler.py
if self.is_ssl and not self.is_authenticated and (auth or self.common_name):

This isint a good security practice and should be changed so that authentication requires a valid username/password regardless of certificate

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions